Restructure omni services and add Chatwoot research snapshot
This commit is contained in:
@@ -0,0 +1,29 @@
|
||||
require 'rails_helper'
|
||||
|
||||
RSpec.describe Avatar::AvatarFromGravatarJob do
|
||||
let(:avatarable) { create(:contact) }
|
||||
let(:email) { 'test@test.com' }
|
||||
let(:gravatar_url) { "https://www.gravatar.com/avatar/#{Digest::MD5.hexdigest(email)}?d=404" }
|
||||
|
||||
it 'enqueues the job' do
|
||||
expect { described_class.perform_later(avatarable, email) }.to have_enqueued_job(described_class)
|
||||
.on_queue('purgable')
|
||||
end
|
||||
|
||||
it 'will call AvatarFromUrlJob with gravatar url' do
|
||||
expect(Avatar::AvatarFromUrlJob).to receive(:perform_later).with(avatarable, gravatar_url)
|
||||
described_class.perform_now(avatarable, email)
|
||||
end
|
||||
|
||||
it 'will not call AvatarFromUrlJob if DISABLE_GRAVATAR is configured' do
|
||||
with_modified_env DISABLE_GRAVATAR: 'true' do
|
||||
expect(Avatar::AvatarFromUrlJob).not_to receive(:perform_later).with(avatarable, gravatar_url)
|
||||
described_class.perform_now(avatarable, '')
|
||||
end
|
||||
end
|
||||
|
||||
it 'will not call AvatarFromUrlJob if email is blank' do
|
||||
expect(Avatar::AvatarFromUrlJob).not_to receive(:perform_later).with(avatarable, gravatar_url)
|
||||
described_class.perform_now(avatarable, '')
|
||||
end
|
||||
end
|
||||
119
research/chatwoot/spec/jobs/avatar/avatar_from_url_job_spec.rb
Normal file
119
research/chatwoot/spec/jobs/avatar/avatar_from_url_job_spec.rb
Normal file
@@ -0,0 +1,119 @@
|
||||
require 'rails_helper'
|
||||
|
||||
RSpec.describe Avatar::AvatarFromUrlJob do
|
||||
let(:file) { fixture_file_upload(Rails.root.join('spec/assets/avatar.png'), 'image/png') }
|
||||
let(:valid_url) { 'https://example.com/avatar.png' }
|
||||
|
||||
it 'enqueues the job' do
|
||||
contact = create(:contact)
|
||||
expect { described_class.perform_later(contact, 'https://example.com/avatar.png') }
|
||||
.to have_enqueued_job(described_class).on_queue('purgable')
|
||||
end
|
||||
|
||||
context 'with rate-limited avatarable (Contact)' do
|
||||
let(:avatarable) { create(:contact) }
|
||||
|
||||
it 'attaches and updates sync attributes' do
|
||||
expect(Down).to receive(:download).with(valid_url, max_size: Avatar::AvatarFromUrlJob::MAX_DOWNLOAD_SIZE).and_return(file)
|
||||
described_class.perform_now(avatarable, valid_url)
|
||||
avatarable.reload
|
||||
expect(avatarable.avatar).to be_attached
|
||||
expect(avatarable.additional_attributes['avatar_url_hash']).to eq(Digest::SHA256.hexdigest(valid_url))
|
||||
expect(avatarable.additional_attributes['last_avatar_sync_at']).to be_present
|
||||
end
|
||||
|
||||
it 'returns early when rate limited' do
|
||||
ts = 30.seconds.ago.iso8601
|
||||
avatarable.update(additional_attributes: { 'last_avatar_sync_at' => ts })
|
||||
expect(Down).not_to receive(:download)
|
||||
described_class.perform_now(avatarable, valid_url)
|
||||
avatarable.reload
|
||||
expect(avatarable.avatar).not_to be_attached
|
||||
expect(avatarable.additional_attributes['last_avatar_sync_at']).to be_present
|
||||
expect(Time.zone.parse(avatarable.additional_attributes['last_avatar_sync_at']))
|
||||
.to be > Time.zone.parse(ts)
|
||||
expect(avatarable.additional_attributes['avatar_url_hash']).to eq(Digest::SHA256.hexdigest(valid_url))
|
||||
end
|
||||
|
||||
it 'returns early when hash unchanged' do
|
||||
avatarable.update(additional_attributes: { 'avatar_url_hash' => Digest::SHA256.hexdigest(valid_url) })
|
||||
expect(Down).not_to receive(:download)
|
||||
described_class.perform_now(avatarable, valid_url)
|
||||
expect(avatarable.avatar).not_to be_attached
|
||||
avatarable.reload
|
||||
expect(avatarable.additional_attributes['last_avatar_sync_at']).to be_present
|
||||
expect(avatarable.additional_attributes['avatar_url_hash']).to eq(Digest::SHA256.hexdigest(valid_url))
|
||||
end
|
||||
|
||||
it 'updates sync attributes even when URL is invalid' do
|
||||
invalid_url = 'invalid_url'
|
||||
expect(Down).not_to receive(:download)
|
||||
described_class.perform_now(avatarable, invalid_url)
|
||||
avatarable.reload
|
||||
expect(avatarable.avatar).not_to be_attached
|
||||
expect(avatarable.additional_attributes['last_avatar_sync_at']).to be_present
|
||||
expect(avatarable.additional_attributes['avatar_url_hash']).to eq(Digest::SHA256.hexdigest(invalid_url))
|
||||
end
|
||||
|
||||
it 'updates sync attributes when file download is valid but content type is unsupported' do
|
||||
temp_file = Tempfile.new(['invalid', '.xml'])
|
||||
temp_file.write('<invalid>content</invalid>')
|
||||
temp_file.rewind
|
||||
|
||||
uploaded = ActionDispatch::Http::UploadedFile.new(
|
||||
tempfile: temp_file,
|
||||
filename: 'invalid.xml',
|
||||
type: 'application/xml'
|
||||
)
|
||||
|
||||
expect(Down).to receive(:download).with(valid_url, max_size: Avatar::AvatarFromUrlJob::MAX_DOWNLOAD_SIZE).and_return(uploaded)
|
||||
|
||||
described_class.perform_now(avatarable, valid_url)
|
||||
avatarable.reload
|
||||
|
||||
expect(avatarable.avatar).not_to be_attached
|
||||
expect(avatarable.additional_attributes['last_avatar_sync_at']).to be_present
|
||||
expect(avatarable.additional_attributes['avatar_url_hash']).to eq(Digest::SHA256.hexdigest(valid_url))
|
||||
|
||||
temp_file.close
|
||||
temp_file.unlink
|
||||
end
|
||||
end
|
||||
|
||||
context 'with regular avatarable' do
|
||||
let(:avatarable) { create(:agent_bot) }
|
||||
|
||||
it 'downloads and attaches avatar' do
|
||||
expect(Down).to receive(:download).with(valid_url, max_size: Avatar::AvatarFromUrlJob::MAX_DOWNLOAD_SIZE).and_return(file)
|
||||
described_class.perform_now(avatarable, valid_url)
|
||||
expect(avatarable.avatar).to be_attached
|
||||
end
|
||||
end
|
||||
|
||||
# ref: https://github.com/chatwoot/chatwoot/issues/10449
|
||||
it 'does not raise error when downloaded file has no filename (invalid content)' do
|
||||
contact = create(:contact)
|
||||
temp_file = Tempfile.new(['invalid', '.xml'])
|
||||
temp_file.write('<invalid>content</invalid>')
|
||||
temp_file.rewind
|
||||
|
||||
expect(Down).to receive(:download).with(valid_url, max_size: Avatar::AvatarFromUrlJob::MAX_DOWNLOAD_SIZE)
|
||||
.and_return(ActionDispatch::Http::UploadedFile.new(tempfile: temp_file, type: 'application/xml'))
|
||||
|
||||
expect { described_class.perform_now(contact, valid_url) }.not_to raise_error
|
||||
|
||||
temp_file.close
|
||||
temp_file.unlink
|
||||
end
|
||||
|
||||
it 'skips sync attribute updates when URL is nil' do
|
||||
contact = create(:contact)
|
||||
expect(Down).not_to receive(:download)
|
||||
|
||||
expect { described_class.perform_now(contact, nil) }.not_to raise_error
|
||||
|
||||
contact.reload
|
||||
expect(contact.additional_attributes['last_avatar_sync_at']).to be_nil
|
||||
expect(contact.additional_attributes['avatar_url_hash']).to be_nil
|
||||
end
|
||||
end
|
||||
Reference in New Issue
Block a user